Warn when temporal primitive is not formatted correctly #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FHIR types dateTime, date, time, and instant all have required formats. If a value of one of these types does not match the format, emit a warning. The rule to set this value is still created.
cmoesel
requested changes
Mar 14, 2024
There was a problem hiding this comment.
This works well. Thank you!
In regard to your question, I think we should report out the name of the entity for which we found the problem; otherwise it's more difficult for the user to find the issue.
In the extractor, we already have other cases where we do this by passing in the SD with the ED. In getFSHValue, it looks like you'll need to add an additional argument (as you noted).
jafeltra
reviewed
Mar 20, 2024
Warning message for concept caret rules includes the concept path. Warning message for values on Instances uses the target id instead of name.
jafeltra
reviewed
Mar 21, 2024
Update test for caret rule on profile to more closely resemble realistic output.
jafeltra
approved these changes
Mar 28, 2024
cmoesel
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes task CIMPL-1241. See also FSHOnline #152.
The FHIR types dateTime, date, time, and instant all have required formats. If a value of one of these types does not match the format, emit a warning. The rule to set this value is still created.
Something I'm thinking about for this is the usefulness of the warning message. Right now, it has the rule path, but no indication of what entity has the incorrectly formatted value. I could send along the entity name to
getFshValueto use in the message, since by the time the value is returned, the information about the FHIR type is gone. Please let me know what you think about this warning message.