Create Aliases with supported characters (and warn on provided unsupported aliases) #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace any unsupported characters with '-' - Include SUSHI's new warning when processing aliases with unsupported characters
mint-thompson
previously approved these changes
Mar 4, 2024
There was a problem hiding this comment.
I think the implementation you went with for replacing unsupported characters is reasonable. The only other way I can think of implementing this is with a replacement function that checks the match offset, but I don't like that as much as your implementation.
cmoesel
requested changes
Mar 6, 2024
mint-thompson
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates that aliases that GoFSH creates to ensure that only supported characters are included in the Alias name. To do this, I replaced any unsupported character with
-. The PR also makes it so that when provided Aliases use unsupported characters, GoFSH logs the same warning that SUSHI now does.I couldn't figure out a more elegant way to ignore the leading
$in alias names with the regex, so if I missed something obvious, I'm happy to make the regex ignore that character so the full replacement can be done withalias.replace(...)