-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow to automatically convert pull requests to draft #6460
Conversation
This reverts commit 9756195.
I am missing the bigger picture here. What does this solve exactly? |
It's solving the problem that I want PRs to be drafts when they are not ready for review because the person that opened it still wants to implement additional things. People will forget to do this, because in the repo settings we can not set PRs to be drafts by default. So I added this action to do it for us. It's not the most important thing, but it was easier than the manipulations of the project status that I have in mind to automate the milestone overview. I picked this to get familiar with automatic workflows that use github cli and are triggered by events. I should probably describe that in detail in an issue, so someone else can pick the further automations up. |
I see, but the downside is that not all pull requests are necessarily unfinished. But there are pros/cons to everything, haha. |
@@ -0,0 +1,14 @@ | |||
name: Convert PRs to Draft on Opening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this repository has no global license I would add the standard MIT license at the top of the file, see also the other workflows that have this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit unelegant to specify this on the file level, but until we have a better solution I will do this.
Luckily it's just a click of a button when the pull request is ready to be reviewed |
I agree, I can see the value. At a minimum it will help to identify what contributions are ready to be reviewed. |
@BlackYps I think this approach does not work when a pull request originates from a fork. See also an error message:
Shall I disable the workflow for now? |
First of possibly many workflows to help us automate project management