Improve lobby and chat reconnection; allow user to create custom game filters #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes segfault on closing player card when rating history is not fully loaded
* add callbacks for api errors * trigger disconnection signals when needed * add separate reconnector for chat, because it can disconnect on its own
it has game_id now, so we can check if we can kill running fa process
applied to game list on play tab
it was increased in a50f36b from 3 to 60, but since then faf-uid calculator was improved and reconnection process takes much less time 60 secs now look a bit harsh, so let's relax th interval to 10 seconds
to avoid ValueErrors in logs
and improve var name in group_achievements method and fix minor typing issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.