Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LuaPlus replication: LuaObject #106

Merged
merged 20 commits into from
Dec 3, 2024
Merged

LuaPlus replication: LuaObject #106

merged 20 commits into from
Dec 3, 2024

Conversation

4z0t
Copy link
Member

@4z0t 4z0t commented Nov 21, 2024

  • replicates various methods of LuaObject
  • introduces Pairs and IPairs iterators as alternative to LuaTableIterator used by LuaPlus

Hdt80bro
Hdt80bro requested changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@Hdt80bro Hdt80bro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, though I'm not a fan of how the iterators are set up

include/LuaAPI.h Outdated Show resolved Hide resolved
include/LuaAPI.h Show resolved Hide resolved
include/LuaAPI.h Outdated Show resolved Hide resolved
include/LuaAPI.h Outdated Show resolved Hide resolved
include/LuaAPI.h Outdated Show resolved Hide resolved
include/LuaAPI.h Show resolved Hide resolved
include/LuaAPI.h Show resolved Hide resolved
include/LuaAPI.h Outdated Show resolved Hide resolved
section/Lua/Iterators/IPairs.cxx Outdated Show resolved Hide resolved
section/Lua/LuaObject.cxx Show resolved Hide resolved
@4z0t
Copy link
Member Author

4z0t commented Dec 1, 2024

@Hdt80bro this should be fine now.

@4z0t 4z0t merged commit 276b07f into FAForever:master Dec 3, 2024
1 check passed
@4z0t 4z0t deleted the LuaPLusReplication branch December 3, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hdt80bro Hdt80bro Hdt80bro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4z0t @Hdt80bro