feat: pass ExecutionInput to getOrElse method #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please add a description with the reason for this? |
tapaderster
approved these changes
Jan 25, 2024
samuelAndalon
added a commit
that referenced
this pull request
Jan 25, 2024
### 📝 Description trying to implement a distributed cache mechanism for parsed and validated operations, in the `getOrElse` method is where we would be setting the operation into an external cache, for that, we need access to the actual operation, which is included in the `ExecutionInput`. No more changes are needed given that the action of storing the parsed and validated operation is potentially async, but we don't care about the result.
samuelAndalon
added a commit
that referenced
this pull request
Jan 25, 2024
### 📝 Description trying to implement a distributed cache mechanism for parsed and validated operations, in the `getOrElse` method is where we would be setting the operation into an external cache, for that, we need access to the actual operation, which is included in the `ExecutionInput`. No more changes are needed given that the action of storing the parsed and validated operation is potentially async, but we don't care about the result. ### 📝 Description ### 🔗 Related Issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
trying to implement a distributed cache mechanism for parsed and validated operations, in the
getOrElsemethod is where we would be setting the operation into an external cache, for that, we need access to the actual operation, which is included in theExecutionInput.No more changes are needed given that the action of storing the parsed and validated operation is potentially async, but we don't care about the result.