fix(app): secrets json schema

ExpediaGroup · Nov 15, 2023 · 4f06799 · 4f06799
1 parent 5c089f7
commit 4f06799
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/app/backend/src/schema.ts b/app/backend/src/schema.ts
@@ -14,8 +14,8 @@ export const updateBaseImagesInputSchema = z.object({
 export const secretsJsonSchema = z.record(
   z.string(),
   z.object({
-    githubToken: z.string(),
-    githubApiUrl: z.string()
+    githubToken: z.string().min(1),
+    githubApiUrl: z.string().optional()
   })
 );
 export type FetchCurrentPageInput = z.infer<typeof fetchCurrentPageInputSchema>;

diff --git a/app/backend/test/getOctokit.test.ts b/app/backend/test/getOctokit.test.ts
@@ -26,6 +26,22 @@ describe('getOctokitOptions', () => {
     });
   });
 
+  it('does not throw if githubApiUrl is not provided', () => {
+    (readFileSync as jest.Mock).mockImplementation(() => ({
+      toString: jest.fn(() =>
+        JSON.stringify({
+          'github-owner/github-repo': {
+            githubToken: 'some-token'
+          }
+        })
+      )
+    }));
+    getOctokit('github-owner', 'github-repo');
+    expect(Octokit).toHaveBeenCalledWith({
+      auth: 'some-token'
+    });
+  });
+
   it('throws error if token not found', () => {
     (readFileSync as jest.Mock).mockImplementation(() => ({
       toString: jest.fn(() => JSON.stringify({}))