Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show auto-complete hints for tag based search in haystack search bar #261

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

doctorXWrites
Copy link
Contributor

No description provided.

@codefromthecrypt
Copy link

show values of what?

@doctorXWrites
Copy link
Contributor Author

@doctorXWrites
Copy link
Contributor Author

@adriancole I just created an issue to document the feature. The problem was that whenever we try searching using tags(if traces are indexed by the given tag) there are no auto-populate hints as in dropdown. This PR is to allow the required data to be indexed and stored which would be used to support this feature.

@doctorXWrites doctorXWrites changed the title Show values show auto-complete hints for tag based search in haystack search bar Aug 13, 2019
@codefromthecrypt
Copy link

makes sense, we have the same feature and same concerns. because elasticsearch is so easy to overload, we also have a limiter as writing same tag many times increases index pressure https://github.com/openzipkin/zipkin/tree/master/zipkin-storage/elasticsearch#autocomplete-indexing

@ashishagg
Copy link
Contributor

ashishagg commented Aug 14, 2019

makes sense, we have the same feature and same concerns. because elasticsearch is so easy to overload, we also have a limiter as writing same tag many times increases index pressure https://github.com/openzipkin/zipkin/tree/master/zipkin-storage/elasticsearch#autocomplete-indexing

We handle this by flushing the documents to ES at a regular interval (configurable). This handles duplicate documents and reduce the indexing pressure. Do note that tags(or what we call as whitelisted index fields) having 'showValues' enabled, goes into a different ES index for this autocomplete feature.

@codefromthecrypt
Copy link

codefromthecrypt commented Aug 14, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants