Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refractor!: rename blindness effectype #317

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

MikeSus1
Copy link

@MikeSus1 MikeSus1 commented Dec 19, 2024

Description

Describe the changes

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

This change only make it so the effect name match the one ingame, i got told it was on purpose to avoid a breaking change, but the old effect "blinded" is now "blurred" so it would change the effect behaviour anyways.


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Dec 19, 2024
@MikeSus1 MikeSus1 changed the title Fix EffectType fix: blindness effectype Dec 19, 2024
replace all blinded by blurred
docs blindness effect
@MikeSus1 MikeSus1 changed the title fix: blindness effectype refractor!: blindness effectype Dec 20, 2024
@MikeSus1 MikeSus1 changed the title refractor!: blindness effectype refractor!: rename blindness effectype Dec 20, 2024
@BoltonDev BoltonDev changed the base branch from scpsl14 to dev December 23, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants