feat: Objective wrappers #316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they seem kinda useless but yamato wasnts them so ok
|
@VALERA771 would be great to also have this type of stuff in an event, for when influence is gained and for when the timer is reduced |
|
maybe it's need an event too..... if no one done that i can make it |
Misfiy
approved these changes
Dec 28, 2024
Misfiy
approved these changes
Dec 30, 2024
louis1706
approved these changes
Dec 30, 2024
|
@VALERA771 I see you added a completing objective event, is this event related to my earlier comment? if so I can't see any method to get how the stats changed by completing the objective, is there some sort of method already existing? |
|
@VALERA771 is this getting merged soon? |
louis1706
reviewed
Jan 7, 2025
Comment on lines
+45
to
+53
| if (newRole == RoleTypeId.None) | ||
| { | ||
| if (player.Role == RoleTypeId.ClassD) | ||
| newRole = RoleTypeId.ChaosConscript; | ||
| else if (player.Role == RoleTypeId.Scientist) | ||
| newRole = RoleTypeId.NtfSpecialist; | ||
| else | ||
| newRole = player.Role; | ||
| } |
There was a problem hiding this comment.
remove this it's not logical for what name you gave as argument newRole
I wanted to test event. Don't have time rn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Adding wrappers for Objective instances. Possible new objectives will be added soon (ScpObjectiveBase is not used...)
What is the current behavior? (You can also link to an open issue here)
No wrappers
What is the new behavior? (if this is a feature change)
Profit
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
I don't know english so idk what to write in docs. Pls help me ;(
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other