Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Friendly Fire fix - maybe #283

Closed

Conversation

Undid-Iridium
Copy link

Friendly Fire fix - maybe

Other information:

https://discord.com/channels/656673194693885975/1312025728732368916/1312739817431502889


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [?] Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Misaka-ZeroTwo
Copy link
Collaborator

Misaka-ZeroTwo commented Dec 2, 2024

Note: FF is working currently. Nothing is broken atm.

@VALERA771
Copy link

So is this PR needed if FF is working fine?

@Undid-Iridium
Copy link
Author

Post keep opening with FF issues and then closing, so I keep opening in case there is an issue

@louis1706 louis1706 changed the title Friendly Fire fix - maybe fix: Friendly Fire fix - maybe Dec 26, 2024
@louis1706 louis1706 changed the base branch from scpsl14 to dev December 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants