Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themable components #231

Merged
merged 56 commits into from
Dec 12, 2023
Merged

Themable components #231

merged 56 commits into from
Dec 12, 2023

Conversation

snixtho
Copy link
Member

@snixtho snixtho commented Dec 6, 2023 •
edited
Loading

This pull request adds a full featured theme system.

Features:

  • Define default theme options for any component or manialink
  • Override themes from core or other modules
  • Replace components fully with other components
  • Provides default theme options such as primary and secondary colors, as well as utility colors.
  • Can override theme options from the config.
  • Several utilities for font and colors.
  • The general theme object and some utilities are available as global variables in mainalinks.
  • Add all available in-game icons defined in a class for easy access.

All existing templates has been updated to use the new theme system (main reason for so many changed files).

ManiaTemplates is also updates which includes global variables.

snixtho added 30 commits November 15, 2023 13:47
@snixtho
Create theme manager
34c6f3a
@snixtho
dont include default theme
364ea6b
@snixtho
fix err
d4f8d09
@snixtho
again
54aef6e
@snixtho
add theme builder tests
a4fe60a
@snixtho
Set effective manialink name based on theme config.
2edec8b
@snixtho
Add ability to access theme options, option fallback to config. Confi…
192d7d9 
…g allows dynamically setting options. Also fix tests.
@snixtho
fix invalid theme option access
27ad8ff
@snixtho
Avoid generating the theme config the normal way.
26e3430
@snixtho
There can now be multiple themes active at the same time, and themes …
c3df126 
…can override other themes.
@snixtho
rename options
74990b7
@snixtho
Update ManiaTemplates to fix dynamic global variables.
d787a18
@snixtho
Add color utilities for modifying lightness of a color.
4aafb3c
@snixtho
begin default Theme
be30b09
@snixtho
Add luma and grayscale calculation utilities.
e9f31e9
@snixtho
some comments
3e04de2
@snixtho
set default component theme
9289440
@snixtho
add icons
1be30dd
@snixtho
add kenney icons
4879f4b
@snixtho
Use theme for alert
a25e9f6
@snixtho
Use theme for checkbopx
fb31276
@snixtho
use theme for radio button
9b41b04
@snixtho
use theme for switch
3fffda9
@snixtho
Theme for Asay
bbd2fc3
@snixtho
use theme for current map module
27c53fd
@snixtho
fastest cp module theme and refactor
dceba2b
@snixtho
some fixes and theme for live ranking module
abc9e43
@snixtho
match ranking theme
8cface3
@snixtho
Theme for ready widget.
527d3f7
@snixtho
Fixes to MOTD templates.
13b7908
This was linked to issues Dec 6, 2023
UI/UX Design #23
Closed
Components should be theme-able #229
Closed
AtomicLiquid
AtomicLiquid reviewed Dec 7, 2023
View reviewed changes
src/EvoSC.Common/Config/Mapping/Toml/ThemeConfigOptionsMapper.cs Outdated Show resolved Hide resolved
src/EvoSC.Common/Themes/ThemeManager.cs Outdated Show resolved Hide resolved
src/EvoSC.Common/Util/ColorUtils.cs Outdated Show resolved Hide resolved
src/EvoSC.Common/Util/ColorUtils.cs Outdated Show resolved Hide resolved
src/EvoSC.Common/Util/ColorUtils.cs Show resolved Hide resolved
src/EvoSC.Manialinks/Templates/FormEntry.mt Outdated Show resolved Hide resolved
src/EvoSC.Manialinks/Util/GameIcons.cs Outdated Show resolved Hide resolved
src/EvoSC/ApplicationSetup.cs Show resolved Hide resolved
src/Modules/ASayModule/ASayModule.csproj Show resolved Hide resolved
src/Modules/CurrentMapModule/CurrentMapModule.csproj Show resolved Hide resolved
snixtho and others added 15 commits December 9, 2023 10:24
@snixtho @AtomicLiquid
Update src/EvoSC.Common/Util/ColorUtils.cs
f44e7b6 
Co-authored-by: AtomicLiquid <[email protected]>
@snixtho
optimize usings
6f91122
@snixtho
Merge remote-tracking branch 'origin/229-themable-components' into 22…
f38e4e3 
…9-themable-components
@snixtho
fix potential null exception
8d5da75
@snixtho
fix sonarcloud issues
f993a11
@snixtho
fix tests
73b5205
@snixtho
fix more sonarcloud
f604650
@snixtho
add async postfix
a0159c3
@snixtho
Merge branch 'master' into 229-themable-components
0477d1c
@snixtho @AtomicLiquid
Update src/EvoSC.Common/Config/Mapping/Toml/ThemeConfigOptionsMapper.cs
ee5aa1f 
Co-authored-by: AtomicLiquid <[email protected]>
@snixtho
move public method up
c3991c5
@snixtho @AtomicLiquid
Update src/EvoSC.Common/Util/ColorUtils.cs
e848f04 
Co-authored-by: AtomicLiquid <[email protected]>
@snixtho @AtomicLiquid
Update src/EvoSC.Common/Util/ColorUtils.cs
fa681ce 
Co-authored-by: AtomicLiquid <[email protected]>
@snixtho
remove commented code
2576bd3
@snixtho
Merge remote-tracking branch 'origin/229-themable-components' into 22…
d0c8554 
…9-themable-components
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

17.0% 17.0% Coverage
0.0% 0.0% Duplication

@snixtho snixtho merged commit e072604 into master Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtomicLiquid AtomicLiquid AtomicLiquid left review comments

@araszka araszka araszka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Components should be theme-able UI/UX Design
3 participants
@snixtho @araszka @AtomicLiquid