fix dependency sorting not removing the node its processing (#295)

EvoEsports · Sep 29, 2024 · 807fc5e · 807fc5e
1 parent f8ac60d
commit 807fc5e
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/EvoSC.Modules/Util/SortedModuleCollection.cs b/src/EvoSC.Modules/Util/SortedModuleCollection.cs
@@ -55,11 +55,7 @@ private List<T> GetSortedModules()
                 selected = dependent.Key;
             }
 
-            if (selected != null)
-            {
-                dependencyGraph.Remove(selected);
-            }
-            else
+            if (selected == null)
             {
                 break;
             }
@@ -78,6 +74,11 @@ private static void RemoveDependent(DependencyGraph dependencyGraph, KeyValuePai
                 dependencies.Value.Remove(dependent.Key);
             }
         }
+
+        if (dependencyGraph.ContainsKey(dependent.Key))
+        {
+            dependencyGraph.Remove(dependent.Key);
+        }
     }
 
     private DependencyGraph MakeDependencyGraph()