Fix plugin unload #1213
Merged
Fix plugin unload #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow this is impressing! thanks! |
|
I did a little indentation fix and merged :D |
|
Thanks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some memory leaks reported in #1201.
But it also fixes an issue in dns_spoof plugin:
If the plugin gets activated everything works as expected. When the plugin gets deactivated and re-activated, the plugin doesn't know about any information specifiied in the etter.dns configuration file.
This is due to an too-early free of entries read from
etter.dnsfile.However the ASAN reports are calmed down only when #1205 has been merged.