[IR-3773]: fix calculateAndApplyOffset regression (#10939)

* reposition for topOverflow in calculateAndApplyOffset * rm popupRef dependency --------- Co-authored-by: Aditya Mitra <[email protected]>
EtherealEngine · Aug 17, 2024 · 76cda41 · 76cda41
1 parent 64f7afd
commit 76cda41
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/common/src/utils/offsets.ts b/packages/common/src/utils/offsets.ts
@@ -32,13 +32,21 @@ export const calculateAndApplyYOffset = (element: HTMLElement | null, additional
   const popupBounds = getBounds(element)
   const viewportBounds = getViewportBounds(new Bounds())
 
+  const overflowTop = viewportBounds.top - (popupBounds?.top ?? 0)
   const overflowBottom =
     (popupBounds?.top ?? 0) + (popupBounds?.height ?? 0) - (viewportBounds.top + viewportBounds.height)
+
   let offsetY = 0
 
-  if (overflowBottom > 0) {
-    offsetY = -(popupBounds?.height ?? 0) + additionalOffset
+  if (overflowTop > 0) {
+    // popup is overflowing at the top, move it down
+    offsetY = overflowTop
+  } else if (overflowBottom > 0) {
+    // popup is overflowing at the bottom, move it up
+    offsetY = -overflowBottom
   }
 
+  offsetY += additionalOffset
+
   element.style.transform = `translateY(${offsetY}px)`
 }