feat(card): Add component tokens #8605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
eriklharper
reviewed
Jan 17, 2024
macandcheese
commented
Jan 17, 2024
| * @prop --calcite-card-border-color: Specifies the border color of the component. | ||
| * @prop --calcite-card-box-shadow: Specifies the box shadow of the component. | ||
| * @prop --calcite-card-corner-radius: Specifies the corner radius of the component. | ||
| * @prop --calcite-card-subtitle-color: Specifies the color of the component's `"subtitle"` slot. |
There was a problem hiding this comment.
Places we accept both a prop and a slot, it could make sense to have this. I could also see card having props in the future for title / subtitle, keeping the slot for more advanced cases, so maybe these are fine to leave.
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
macandcheese
removed
the
Stale
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
requested changes
Feb 9, 2024
| * @prop --calcite-card-border-color: Specifies the border color of the component. | ||
| * @prop --calcite-card-box-shadow: Specifies the box shadow of the component. | ||
| * @prop --calcite-card-corner-radius: Specifies the corner radius of the component. | ||
| * @prop --calcite-card-subtitle-color: Specifies the color of the component's `"subtitle"` slot. |
There was a problem hiding this comment.
we should not create tokens for slotted elements.
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
macandcheese
removed
the
Stale
|
@alisonailea could you give this one another check after the last updates? Thanks! |
alisonailea
approved these changes
Feb 13, 2024
|
Looks good! |
Elijbet
pushed a commit
that referenced
this pull request
Feb 15, 2024
**Related Issue:** #7180 ## Summary Adds the following public component css properties: `--calcite-card-background-color`: Specifies the background color of the component. `--calcite-card-border-color`: Specifies the border color of the component. `--calcite-card-box-shadow`: Specifies the box shadow of the component. `--calcite-card-corner-radius`: Specifies the corner radius of the component. Adds a Chromatic test and a demo page example. Also replaces broken image links in local demo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following public component css properties:
--calcite-card-background-color: Specifies the background color of the component.--calcite-card-border-color: Specifies the border color of the component.--calcite-card-box-shadow: Specifies the box shadow of the component.--calcite-card-corner-radius: Specifies the corner radius of the component.Adds a Chromatic test and a demo page example. Also replaces broken image links in local demo.