Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(segmented-control): removes grid option from layout #8019

Merged
merged 1 commit into from
Oct 16, 2023
Merged

docs(segmented-control): removes grid option from layout #8019

merged 1 commit into from
Oct 16, 2023

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Oct 16, 2023 •
edited
Loading

Related Issue: #6981

Summary

Removes layout='grid' option for calcite-segmented-control.

@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Oct 16, 2023
@anveshmekala anveshmekala added low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing. labels Oct 16, 2023
@anveshmekala anveshmekala marked this pull request as ready for review October 16, 2023 18:28
@anveshmekala anveshmekala requested a review from a team as a code owner October 16, 2023 18:28
driskull
driskull approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm, nobody should have been using grid right? it would be in an error state or something not good?

@macandcheese
Copy link
Contributor

Just want to confirm, nobody should have been using grid right? it would be in an error state or something not good?

It just had no effect / associated styles - the component displayed as if the default value was set.

@driskull
Copy link
Member

Sounds good!

@anveshmekala anveshmekala merged commit 881a6f4 into main Oct 16, 2023
14 of 15 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/6981-sengmented-control-remove-grid-layout-option branch October 16, 2023 18:48
@anveshmekala anveshmekala added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
3 - installed Issues that have been merged to master branch and are ready for final confirmation. docs Issues relating to documentation updates only. low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

Successfully merging this pull request may close these issues.
3 participants
@anveshmekala @macandcheese @driskull