chore: add design tokens to monorepo #7948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Designer/manuelacosta
… into designer/jacqueskeet
First push after fix
Merge pull request #81 from Esri/designer/jacqueskeet
…/7180-1.0.0-design-tokens # Conflicts: # .release-please-manifest.json
jcfranco
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Awesome, thanks for resubmitting this one, @alisonailea!
🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️
🕹️🪙🪙🪙🪙🪙🕹️🕹️🪙🪙🕹️🕹️🪙🕹️🕹️🪙🕹️🪙🪙🪙🪙🕹️🪙🕹️🕹️🕹️🪙🕹️🕹️🪙🪙🪙🕹️🪙🕹️
🕹️🕹️🕹️🪙🕹️🕹️🕹️🪙🕹️🕹️🪙🕹️🪙🕹️🪙🕹️🕹️🪙🕹️🕹️🕹️🕹️🪙🪙🕹️🕹️🪙🕹️🪙🕹️🕹️🕹️🕹️🪙🕹️
🕹️🕹️🕹️🪙🕹️🕹️🕹️🪙🕹️🕹️🪙🕹️🪙🪙🕹️🕹️🕹️🪙🪙🪙🕹️🕹️🪙🕹️🪙🕹️🪙🕹️🕹️🪙🪙🕹️🕹️🪙🕹️
🕹️🕹️🕹️🪙🕹️🕹️🕹️🪙🕹️🕹️🪙🕹️🪙🕹️🪙🕹️🕹️🪙🕹️🕹️🕹️🕹️🪙🕹️🕹️🪙🪙🕹️🕹️🕹️🕹️🪙🕹️🕹️🕹️
🕹️🕹️🕹️🪙🕹️🕹️🕹️🕹️🪙🪙🕹️🕹️🪙🕹️🕹️🪙🕹️🪙🪙🪙🪙🕹️🪙🕹️🕹️🕹️🪙🕹️🪙🪙🪙🕹️🕹️🪙🕹️
🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️🕹️
Once this lands, let's make sure to:
- follow-up on comments brought up in feat: calcite-design-tokens in monorepo package #7621
- migrate applicable issues from https://github.com/Esri/calcite-design-tokens/
- archive https://github.com/Esri/calcite-design-tokens/ with a respective README update when ready
alisonailea
changed the title
alisonailea
added
the
low risk
benelan
approved these changes
Oct 6, 2023
| "name": "@esri/calcite-design-tokens", | ||
| "version": "1.0.0", | ||
| "description": "Esri's Calcite Design System Tokens", | ||
| "homepage": "https://github.com/Esri/calcite-design-tokens", |
There was a problem hiding this comment.
The URLs in this package.json need to be updated again
| @@ -0,0 +1,177 @@ | |||
| { | |||
| "[comp-name]": { | |||
| @@ -0,0 +1,238 @@ | |||
| { | |||
| "accordion": { | |||
There was a problem hiding this comment.
This _backup file can be deleted right?
remove missing JS files (will be in v2) point repo and bugs urls to calcite-design-system
benelan
approved these changes
Oct 10, 2023
alisonailea
added
pr ready for visual snapshots
alisonailea
added
p - high
alisonailea
added
low risk
benelan
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Oct 11, 2023
* origin/main: (83 commits) chore: add design tokens to monorepo (#7948) test(input-time-zone): restore common tests (#7963) chore: release next fix(input-time-zone): fix error caused by time zone group filtering (#7971) chore: release next fix(table): Improve scrollbar display (#7967) build: bump timezone-groups (#7962) chore: release next fix(flow-item): update collapsed property when collapse button is clicked (#7960) chore: release main (#7945) chore: release next fix(input-time-zone): fix handling of unknown and cityless time zones from offset display mode (#7947) fix(combobox): fix issue causing value to be cleared when selecting an item (Windows + trackpad) (#7954) chore(deps): update calcite-ui-icons to 3.24.7 (#7949) test(flow-item, panel): add tests for internal property. (#7931) chore: release next fix(panel): fix collapse action title and reverse icon direction (#7927) chore: update issue template labels to support workflows (#7938) build(deps): bump timezone-groups (#7933) build(deps): update dependency @esri/calcite-ui-icons to v3.24.6 (#7925) ...
geospatialem
modified the milestones:
2023 October Priorities - Maintenance Release,
1.9.2 Maintenance Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Merge https://github.com/Esri/calcite-design-tokens/tree/merge/1.0.0-calcite-design-system with https://github.com/Esri/calcite-design-system/tree/main
Includes
calcite-design-tokens as of release 1.0.0
updates to design tokens (removing temp files and backups)
update to github actions to build tokens for visual regression tests