Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(combobox): use async expect for non-throwing test case #11332

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

test(combobox): use async expect for non-throwing test case #11332

wants to merge 1 commit into from
+15 −11

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 17, 2025 •
edited
Loading

Related Issue: N/A

Summary

Adds async assertion to non-throwing test.

References

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 17, 2025
@jcfranco jcfranco requested review from driskull and Elijbet January 17, 2025 21:55
driskull
driskull approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@Elijbet Elijbet Awaiting requested review from Elijbet

Assignees

@jcfranco jcfranco

Labels
skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull