-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(actions): add icon leads notification for calcite-ui-icons requests #11263
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are tagging icon designers in a comment instead of assigning them (or the @Esri/calcite-icon-designers team) to the issue? I think designers would be notified either way, but it assigning would reduce noise for the issue author.
Edit: Actually you can't assign a team to an issue. But assigning the individual designer(s) is still an option.
If we'd rather assign issues to the team, can alter the automation - the intent was to be similar to our new component and spike complete notifications, where:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we'd rather assign issues to the team, can alter the automation - the intent was to be similar to our new component and spike complete notifications, where:
- Icon leads would be notified and could review the request
- If the Icon team would like to proceed with the request, they could assign themselves to follow-up with the requestor once the icon(s) are added
- If the Icon team does not wish to proceed with the request, the issue would be closed with a response to the requestor
Gotcha. I don't remember why we decided to comment/mention instead of assign in previous workflows. Assigning would notify them as well, and would have the added benefit of reducing noise for the requester and showing up in the designer's list of assigned issues so things don't get lost.
We don't need to make the change in this PR, but it's something worth considering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Related Issue: #9922
Summary
Add automation to issues when the
calcite-ui-icons
label is added, where Icon team leads will receive an@
notification via a comment, similar to the new component label automation from the notifyAboutNewComponent script.cc @allieorth, @arowles