Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tile): wrap overflowing text content #11213

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

eriklharper
Copy link
Contributor

Related Issue: #11170

Summary

This PR fixes an issue where overflowing content doesn't stay within the outer bounds of the Tile.

@eriklharper eriklharper requested a review from jcfranco January 6, 2025 22:55
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 6, 2025
@eriklharper eriklharper added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 6, 2025
@eriklharper eriklharper requested a review from driskull January 6, 2025 23:02
@eriklharper eriklharper changed the title fix(tile): wrap overflowing content fix(tile): wrap overflowing text content Jan 7, 2025
Co-authored-by: Matt Driscoll <[email protected]>
@eriklharper eriklharper requested a review from driskull January 7, 2025 23:57
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯

If this doesn't trigger any screenshot changes be sure to add one for the use case.

@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 8, 2025
@eriklharper
Copy link
Contributor Author

👍 💯

If this doesn't trigger any screenshot changes be sure to add one for the use case.

Definitely, thanks for the review and approval! There is this existing story that should capture this use case, and I was surprised that it didn't catch this originally, not sure if it was approved incorrectly or not, but I'll make sure to monitor it and add a new one if necessary.

@eriklharper eriklharper merged commit 732933a into dev Jan 8, 2025
15 checks passed
@eriklharper eriklharper deleted the eriklharper/11170-tile-content-overflow branch January 8, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants