Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(navigation-logo): enable interactive states only when href is specified #11202

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 4, 2025

Related Issue: #9139, #7078

Summary

This prevents any confusing interaction states from being displayed when the navigation logo has no active link.

Note: #11203 should be installed prior to this PR

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Jan 4, 2025
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 4, 2025
@jcfranco jcfranco requested a review from macandcheese January 4, 2025 09:27
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant