Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list, list-item): ensure change and select events are emitted after state is updated #11079

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix(list, list-item): ensure change and select events are emitted after state is updated #11079

merged 1 commit into from
Dec 17, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Dec 17, 2024 •
edited by github-actions bot
Loading

Related Issue: #10731

Summary

Changes calcite-list and calcite-list-item to wait for their update to be complete before emitting the change and selection events.

BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 17, 2024
driskull
driskull approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I wonder if all our selected event emitters should be doing this?

@jcfranco
Copy link
Member Author

Most likely. I'm aiming to have similar components follow this pattern soon.

@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Dec 17, 2024
@jcfranco jcfranco mentioned this pull request Dec 17, 2024
Open
@jcfranco
Copy link
Member Author

Created a follow-up issue to add a test util to cover this.

@jcfranco jcfranco merged commit c3affff into dev Dec 17, 2024
20 of 21 checks passed
@jcfranco jcfranco deleted the jcfranco/fix-list-event-emit-timing branch December 17, 2024 02:30
@jcfranco jcfranco added the no changelog entry Use the commit override to avoid a changelog entry label Dec 17, 2024
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @driskull