feat(input-time-picker): add hour-format property #10997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lharper/4756-input-time-picker-hour-format
…lharper/4756-input-time-picker-hour-format
…ranch. getMeridiemOrder needs to preserve the order of items received directly by the Intl.DateTimeFormat API.
… and was removed because connectLocalized was also calling it, but now with the useT9n controller we need it back
…o apply, which is great
…rides the corresponding style applied to popover's content div to keep time values from splitting onto 2 lines when the width is constrained.
…esolves to either 12 or 24 depending on the public hour-format property setting. Also refactoring a few places to cut down on duplicate logic when setting the input value.
…locales to use comma decimal separators.
…matOpposite utils
packages/calcite-components/src/components/input-time-picker/input-time-picker.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/time-picker/time-picker.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kitty Hurley <[email protected]>
Co-authored-by: Kitty Hurley <[email protected]>
Are comments no longer resolvable when closed? If keeping it open is preferable, let's change it to a draft and add a comment to make the intent clearer. |
jcfranco
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰
⏰🕛🕛🕛🕛⏰🕛⏰⏰⏰⏰⏰🕛⏰🕛🕛🕛🕛⏰⏰🕛🕛🕛⏰⏰🕛🕛⏰⏰🕛⏰⏰⏰🕛⏰🕛🕛🕛🕛⏰🕛⏰
⏰🕛⏰⏰🕛⏰🕛⏰⏰⏰⏰⏰🕛⏰🕛⏰⏰⏰⏰🕛⏰⏰⏰⏰🕛⏰⏰🕛⏰🕛🕛⏰🕛🕛⏰🕛⏰⏰⏰⏰🕛⏰
⏰🕛🕛🕛🕛⏰🕛⏰⏰🕛⏰⏰🕛⏰🕛🕛🕛⏰⏰⏰🕛🕛⏰⏰🕛⏰⏰🕛⏰🕛⏰🕛⏰🕛⏰🕛🕛🕛⏰⏰🕛⏰
⏰🕛⏰⏰🕛⏰🕛⏰🕛⏰🕛⏰🕛⏰🕛⏰⏰⏰⏰⏰⏰⏰🕛⏰🕛⏰⏰🕛⏰🕛⏰⏰⏰🕛⏰🕛⏰⏰⏰⏰⏰⏰
⏰🕛⏰⏰🕛⏰⏰🕛⏰⏰⏰🕛⏰⏰🕛🕛🕛🕛⏰🕛🕛🕛⏰⏰⏰🕛🕛⏰⏰🕛⏰⏰⏰🕛⏰🕛🕛🕛🕛⏰🕛⏰
⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰⏰
Once comments are addressed, this is good to merge. Great stuff, @eriklharper!
| ...options, | ||
| ...{ step: 0.001 }, | ||
| }); | ||
| const oppositeHourFormat = |
There was a problem hiding this comment.
Let's DRY this up by only defining a variable for the value that changes (merged options with hourFormat in this case). Applies to similar blocks in this PR.
packages/calcite-components/src/components/time-picker/time-picker.e2e.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/time-picker/time-picker.e2e.ts
Show resolved
Hide resolved
packages/calcite-components/src/components/input-time-picker/input-time-picker.tsx
Show resolved
Hide resolved
packages/calcite-components/src/components/input-time-picker/input-time-picker.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/input-time-picker/input-time-picker.tsx
Outdated
Show resolved
Hide resolved
jcfranco
reviewed
Dec 30, 2024
packages/calcite-components/src/components/input-time-picker/input-time-picker.e2e.ts
Show resolved
Hide resolved
…eference cldr-json time and meridiem formats
…-zero langs. Also has the added bonus of being able to put the lang code in the test label.
… for future locale support
eriklharper
added
the
pr ready for visual snapshots
eriklharper
added
pr ready for visual snapshots
…lharper/4756-input-time-picker-hour-format
eriklharper
added
pr ready for visual snapshots
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4756
Summary
This PR exposes a new
hour-formatproperty toinput-time-pickerandtime-pickerthat overrides the locale's defaulthourCyclesetting, allowing a 12-hour locale to be formatted in 24-hour time and vice versa. Confirmed with the i18n team that the bulgarianч.character (abbreviation for "hours") should not display for short and medium time formats.