-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clipboard support to //deform #2276
base: master
Are you sure you want to change the base?
Conversation
d7499d1
to
7077c74
Compare
Codecov Report
@@ Coverage Diff @@
## master #2276 +/- ##
===========================================
+ Coverage 8.68% 8.71% +0.02%
- Complexity 1041 1044 +3
===========================================
Files 881 883 +2
Lines 46291 46370 +79
Branches 5160 5158 -2
===========================================
+ Hits 4022 4042 +20
- Misses 42087 42144 +57
- Partials 182 184 +2
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
worldedit-core/src/main/java/com/sk89q/worldedit/function/factory/Deform.java
Outdated
Show resolved
Hide resolved
7077c74
to
e7f8480
Compare
rebased |
39257c9
to
bb880d3
Compare
rebased this on top of most of the //placement PR in order to be able to use the new Placement system for the Deform brush. |
bb880d3
to
6116518
Compare
83eb6aa
to
7f88a3e
Compare
7f88a3e
to
52e6fb2
Compare
Moved the (contentious and not yet rebased) I might rebase |
worldedit-core/src/main/java/com/sk89q/worldedit/math/transform/SimpleTransform.java
Outdated
Show resolved
Hide resolved
52e6fb2
to
9b9275a
Compare
e3e2784
to
a5b9c92
Compare
Checks are passing, deform-brush-clipboard pushed Two alternatives were considered: option C: add 0.5 to the region/clipboard's min/max |
worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/EditSession.java
Outdated
Show resolved
Hide resolved
a5b9c92
to
ef8b77b
Compare
I'm done testing and enabled auto-merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I'd prefer if someone else reviewed this too as I'm less familiar with the expression/deform system
ef8b77b
to
11a4425
Compare
just force-pushed to change a javadoc description from input/output to source/target |
11a4425
to
2e0ecdb
Compare
force-pushed to rename SimpleTransform to ScaleAndTranslateTransform, as suggested by @wizjany. |
I just rebased this again. |
…o offsetPlacement
2e0ecdb
to
cc32178
Compare
I'd like to give it a review, but I can't immediately because I'm working. |
this is still done and just pending a review :) |
This adds a -l flag to
//deform
and//brush deform
which, when used, will fetch blocks from the clipboard instead of the world.Additionally, coordinate transformations that would normally be based on the selection position+size are based on the clipboard's position+size when using that mode.
Example usage:
The shape on the right is the result of copying the square shape on the left and deforming the selection with the command on screen.
This is the following brush using the same clipboard contents as before:
//brush deform -l sphere 6 x=-x;y=0;z=-z
Addresses parts of #1554