Vector extensions testing related changes #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wahajali
reviewed
Dec 13, 2024
wahajali
reviewed
Dec 13, 2024
run-scripts/run-custom-dataset.py
Outdated
| try: | ||
| random_number = random.randint(1, 100000) | ||
| print(f"Running command: {' '.join(command)}") | ||
| output_dir = f"results/pgvector/hnsw/{case['db-label']}/{db_config['provider']}/{db_config['instance-type']}-{str(case['m'])}-{str(case['ef-construction'])}-{ef_search}-{case['case-type']}-{run}-{random_number}" |
There was a problem hiding this comment.
@Sheharyar570 output dir has pgvector/hnsw hardcorded. I guess this was not the final version. Also i'm thinking we can skip adding this file in this PR, assuming this file is for constraint mem case?
wahajali
reviewed
Dec 13, 2024
wahajali
reviewed
Dec 13, 2024
- Added postgres version query in queries.json - Added pg_prewarm and get_stats functions in run-dann and run-hnsw. - Deleted custom-dataset run and config script. - Fixed key issues in hnsw and pvs-sbq run scripts
Sheharyar570
force-pushed
the
dev-vector-ext-testing
branch
from
b0d2736 to
3285ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.