refactor: Tests cleanup and better test isolation #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuroOravec
changed the title
tests/test_component_as_view.py
Outdated
| @@ -150,14 +162,6 @@ def test_replace_slot_in_view(self): | |||
| response.content, | |||
| ) | |||
|
|
|||
| def test_replace_slot_in_view_with_insecure_content(self): | |||
There was a problem hiding this comment.
Shouldn't we still test this?
There was a problem hiding this comment.
Ah, forgot to attach a comment here, but this is a duplicate, it has the same function body as the function below (test_replace_slot_in_view_with_insecure_content)
There was a problem hiding this comment.
But thanks for pointing out, as I'm looking at it now, I guess the first functions probavbly should have used /test_context_insecure/ endpoint instead?
There was a problem hiding this comment.
Yes, you're right. I think I made a typo when I wrote that 😅
There was a problem hiding this comment.
Haha, happens :D Reverted the deletion and fixed the test in 8cc12ef 🎉
dylanjcastillo
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dedent()in test assertions that usedassertHTMLEqualsetUpClassmethod), and the component registry is cleared between tests.autodiscoverfunction to accept an optional mapping function for the import paths. This was needed because in tests, the components dir is not at the top-level, but undertests/.Closes #436