Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up README.md #338

Merged
merged 2 commits into from
Dec 3, 2023
Merged

Clean up README.md #338

merged 2 commits into from
Dec 3, 2023

Conversation

rwblokzijl
Copy link
Contributor

  • Remove trailing whitespace
  • Use the same quotes as django defaults
  • Use consisten name for css and js in tutorial

@rwblokzijl
Clean up README.md
c01fd9a 
- Remove trailing whitespace
- Use the same quotes as django defaults
- Use consisten name for css and js in tutorial
@EmilStenstrom
Copy link
Owner

@rwblokzijl Thank you! We are actually moving towards using style.css and script.js as the default names for components. Would you mind changing the README to use those instead of calendar.js/css instead?

https://github.com/EmilStenstrom/django-components/blob/master/django_components/management/commands/startcomponent.py

@rwblokzijl
Copy link
Contributor Author

@EmilStenstrom done

@EmilStenstrom EmilStenstrom merged commit 63ce90f into EmilStenstrom:master Dec 3, 2023
7 checks passed
@EmilStenstrom
Copy link
Owner

@rwblokzijl Thank you! You're very welcome to improve more things :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwblokzijl @EmilStenstrom