Fix logging leak #357
Merged
Fix logging leak #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when no managed node is found feat(JobTypes.cs): disallow concurrent execution of jobs to prevent potential conflicts fix(NodeChannelSubscribeJob.cs): change NodeUpdateManagement to async to ensure proper execution order refactor(ProcessNodeChannelAcceptorJob.cs): remove unnecessary loggerFactory creation chore(NodeGuard.csproj): update package versions for better compatibility and performance refactor(Withdrawals.razor): simplify JSON parsing and validation logic for better readability refactor(Program.cs): use Serilog for logging, adjust thread pool concurrency, and set up loggerFactory for Quartz feat(LightningClientService.cs): add logging for grpc channel creation for better debugging chore(NodeGuard.Tests.csproj): update Grpc.Core.Api version and add Microsoft.Extensions.Logging.Configuration for testing
… setup due to redundancy feat(LightningClientService.cs): add NullLogger for better logging refactor(LightningClientService.cs): change CreateLightningClient method from static to instance for better encapsulation and testability
…educe code duplication fix(SweepNodeWalletsJob.cs): replace direct instantiation of LightningClient with ILightningClientService.GetLightningClient to improve testability and maintainability style(SweepNodeWalletsJob.cs): remove unnecessary loggerFactory variable and whitespace for cleaner code
RodriFS
previously approved these changes
Dec 12, 2023
* Node disable/enabled. * Code improvements * Removed unscheduled and interrupted job. * Update src/NodeGuard.csproj Co-authored-by: Rodrigo <[email protected]> * Update src/Pages/Nodes.razor Co-authored-by: Rodrigo <[email protected]> * Fix a messsage of the toast. * Added some improvements. * Returned migration logic. * Added migrations files. * Redid migration and renamed field --------- Co-authored-by: Rodrigo <[email protected]>
…when no managed node is found feat(JobTypes.cs): disallow concurrent execution of jobs to prevent potential conflicts fix(NodeChannelSubscribeJob.cs): change NodeUpdateManagement to async to ensure proper execution order refactor(ProcessNodeChannelAcceptorJob.cs): remove unnecessary loggerFactory creation chore(NodeGuard.csproj): update package versions for better compatibility and performance refactor(Withdrawals.razor): simplify JSON parsing and validation logic for better readability refactor(Program.cs): use Serilog for logging, adjust thread pool concurrency, and set up loggerFactory for Quartz feat(LightningClientService.cs): add logging for grpc channel creation for better debugging chore(NodeGuard.Tests.csproj): update Grpc.Core.Api version and add Microsoft.Extensions.Logging.Configuration for testing
… setup due to redundancy feat(LightningClientService.cs): add NullLogger for better logging refactor(LightningClientService.cs): change CreateLightningClient method from static to instance for better encapsulation and testability
…educe code duplication fix(SweepNodeWalletsJob.cs): replace direct instantiation of LightningClient with ILightningClientService.GetLightningClient to improve testability and maintainability style(SweepNodeWalletsJob.cs): remove unnecessary loggerFactory variable and whitespace for cleaner code
…fix-logging-leak # Conflicts: # src/Helpers/JobTypes.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix on thread leak, potentially due to a leak in the logger factory of gRPC.