Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better New-File Dialog #264

Merged
merged 4 commits into from
May 10, 2017
Merged

Better New-File Dialog #264

merged 4 commits into from
May 10, 2017

Conversation

mrjacobbloom
Copy link
Contributor

See #218

@mrjacobbloom mrjacobbloom changed the base branch from master to gh-pages May 5, 2017 06:15
@TheInitializer
Copy link

Ooh, this is being implemented! I'll check it out.

TheInitializer
TheInitializer previously requested changes May 9, 2017
View reviewed changes
Copy link

@TheInitializer TheInitializer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, seems to work. It's not draggable or anything but I don't think that matters and I don't know how to do that. I'd add cursor: pointer to .add-file though.

@mrjacobbloom
Copy link
Contributor Author

I'd add cursor: pointer to .add-file though.

Good idea, I hadn't styled .add-file at all in this PR but now does seem like a good time to get around to it

@mrjacobbloom
Copy link
Contributor Author

I updated the file pane to use the same styles as the new file popup (which includes hover styles and cursor: pointer)
screen shot 2017-05-08 at 9 50 59 pm

@mrjacobbloom mrjacobbloom dismissed TheInitializer’s stale review May 9, 2017 04:02

updated with requested changes

@mrjacobbloom
Copy link
Contributor Author

sorry I'm new to these review things and idk if I was just supposed to do that--I'd just like someone's go-ahead before merging this in

@matthewr6
Copy link
Contributor

idk but it seems right

@mrjacobbloom
Copy link
Contributor Author

ok I got a thumbs-up reaction. that seems good enough

@mrjacobbloom mrjacobbloom merged commit 276555b into gh-pages May 10, 2017
@mrjacobbloom mrjacobbloom deleted the newfile-dialog branch May 10, 2017 03:29
@towerofnix
Copy link
Member

screen shot 2017-05-10 at 1 46 16 pm

"MY AWESOME

DOCUMENT.html"

(This probably belongs in a new issue.)

@mrjacobbloom
Copy link
Contributor Author

welp xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheInitializer TheInitializer Awaiting requested review from TheInitializer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrjacobbloom @TheInitializer @matthewr6 @towerofnix