Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define estimation return types as library types #412

Open
nahueespinosa opened this issue Jul 15, 2024 · 0 comments
Open

Define estimation return types as library types #412

nahueespinosa opened this issue Jul 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nahueespinosa
Copy link
Member

nahueespinosa commented Jul 15, 2024

Feature description

Since #275, we have some estimation algorithms (estimate_clusters) that return local structs for convenience instead of creating tuples of values. We should make those types first-class citizens in the library.

Context: #275 (comment)

Implementation considerations

They should perhaps be specialized for different types of states.
It may be a good opportunity to revisit some algorithm implementations and apply the law of useful return:

A procedure should return all the potentially useful information it computed.
― Alexander A. Stepanov, From Mathematics to Generic Programming

See for reference https://en.cppreference.com/w/cpp/algorithm/ranges#Return_types.

@nahueespinosa nahueespinosa added the enhancement New feature or request label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant