Fixed GetCompositeScheduleRequest invalid optional access #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed an issue in GetCompositeScheduleRequest command handler.
When the optional field
chargingRateUnit
is not included in the message request, the handler attempts to read an empty optional value and throws anstd::bad_optional_access
exception.OCPP Version
OCPP2.0.1
Describe your solution
When this optional field is missing in the request, the value to use will be the first supported charging rate unit defined in the device model (
ChargingScheduleChargingRateUnit
).Otherwise if no valid unit is defined in this variable, the request must be rejected.
Checklist before requesting a review