Feature/958 reservation all connectors reserved #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaikez
requested review from
Pietfried,
hikinggrass and
marcemmers
as code owners
This was referenced Nov 27, 2024
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
from
e5de72b to
f73e62e
Compare
Pietfried
requested changes
Dec 5, 2024
Comment on lines
80
to
95
| if (valid) { | ||
| if (device_model->get_optional_value<bool>(ControllerComponentVariables::ReservationCtrlrAvailable) | ||
| .value_or(false)) { | ||
| if (!this->reserve_now_callback.has_value() or this->reserve_now_callback == nullptr) { | ||
| EVLOG_error << "Reservation is set to 'Available' and 'Enabled' in device model, but " | ||
| "reserve_now_callback is not implemented."; | ||
| } | ||
|
|
||
| if (!this->cancel_reservation_callback.has_value() or this->cancel_reservation_callback == nullptr) { | ||
| EVLOG_error | ||
| << "Reservation is set to 'Available' and 'Enabled' in device model, but cancel_reservation " | ||
| "callback is not implemented"; | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This looks like it could be moved inside the upper if (valid) and it does not set the valid variable to false in case of the error logs
There was a problem hiding this comment.
Ah good catch
I put it in this if (valid) so it will not continue if the previous were not valid. But maybe it is a good idea to have a message of all not valid callbacks instead of fixing one and getting an error about the next. So changed it accordingly as you asked indeed :).
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
from
f73e62e to
d79bf58
Compare
Pietfried
approved these changes
Dec 11, 2024
Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
…set it back to 'available' again. and it is not necessary for octt. Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
…ged runtime (readwrite). Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
maaikez
force-pushed
the
feature/958-reservation-all-connectors-reserved
branch
from
c10ee90 to
daa1c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update status document for reservations
See other related pull requests:
EVerest/everest-core#972
EVerest/everest-utils#171
Issue ticket number and link
Checklist before requesting a review