Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket_uri: return std::expected #219

Closed
wants to merge 20 commits into from
Closed

websocket_uri: return std::expected #219

wants to merge 20 commits into from

Conversation

Dominik-K
Copy link
Contributor

No description provided.

@Dominik-K
new helpers::URIAppendPath()
d590bae 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
append chargepoint ID to CSMS-URI
28a3d52 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
rename cs_uri to csms_uri
ad9f9dc 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
fix in websocket_plain.cpp; consolidate both to avoid copy and past…
ed1495c 
…e errors

Signed-off-by: Dominik K <[email protected]>
@Dominik-K
move Uri-struct to websocket_common.cpp
ec0d20d 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
v201: use SecurityCtrlrIdentity instead ChargePointId
5a7103f 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
Merge branch 'main' into fix/websockets/CP-ID
54e4f1c 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
merge fix
6062783 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
use set_path(), use websocketpp with workaround
f2d05dd 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
transfer uri around to avoid re-parsing
fb54d8f 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
rename to websocket_uri.*pp
d4323ed 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
reworked with static Uri::parse_from_string()
977c6d1 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
use set_connection_options() generically
88b8abd 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
find . -iname '*.*pp' | xargs clang-format -i
606a26b 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
fix linter issues
3143cba 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
Codacy & own PR-reviews
bbfafbf 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
clang-format again :-(
8b5b665 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
make Codacy happy again!?!
79994bb 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
add tl::expected
4b14e76 
Signed-off-by: Dominik K <[email protected]>
@Dominik-K
try out using it
4628b45 
Signed-off-by: Dominik K <[email protected]>
Base automatically changed from fix/websockets/CP-ID to main November 13, 2023 12:51
@Pietfried
Copy link
Contributor

@Dominik-K : Can this one be closed?

@Dominik-K
Copy link
Contributor Author

Yes. I might come back to it later.

@Dominik-K Dominik-K closed this Jan 15, 2024
@Dominik-K Dominik-K deleted the dependency/expected branch January 15, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried will be requested when the pull request is marked ready for review Pietfried is a code owner

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass will be requested when the pull request is marked ready for review hikinggrass is a code owner

@marcemmers marcemmers Awaiting requested review from marcemmers marcemmers will be requested when the pull request is marked ready for review marcemmers is a code owner

@maaikez maaikez Awaiting requested review from maaikez maaikez will be requested when the pull request is marked ready for review maaikez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dominik-K @Pietfried