B06:- Get variables requests #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcemmers
reviewed
Oct 18, 2023
lib/ocpp/v201/device_model.cpp
Outdated
| @@ -112,6 +113,12 @@ GetVariableStatusEnum DeviceModel::request_value(const Component& component_id, | |||
| return GetVariableStatusEnum::NotSupportedAttributeType; | |||
| } | |||
|
|
|||
| // only internal functions can access WriteOnly variables | |||
| if (attribute_opt.value().mutability.has_value() && !allow_write_only && | |||
There was a problem hiding this comment.
Slight nitpick but I normally prefer the simple bool comparison values up front before the longer checks:
Suggested change
| if (attribute_opt.value().mutability.has_value() && !allow_write_only && | |
| if (!allow_write_only && attribute_opt.value().mutability.has_value() && |
Edit: Also they use and instead of &&
SNSubramanya
changed the title
marcemmers
reviewed
Oct 25, 2023
| @@ -719,9 +719,9 @@ void ChargePoint::handle_message(const EnhancedMessage<v201::MessageType>& messa | |||
|
|
|||
| void ChargePoint::message_callback(const std::string& message) { | |||
| auto enhanced_message = this->message_queue->receive(message); | |||
| enhanced_message.message_size = message.size(); | |||
There was a problem hiding this comment.
Just wondering if we would like to do this assignment in the queue itself so 1.6 can use it as well.
marcemmers
approved these changes
Oct 25, 2023
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
…sts a WriteOnly value Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]> fix formatting Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
B06-WriteOnly-Variables
branch
from
9eab486 to
e102ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns a rejected as a response to get variable request for write only variables