Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message logging callback #209

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Add message logging callback #209

merged 3 commits into from
Nov 3, 2023

Conversation

marcemmers
Copy link
Contributor

No description provided.

@hikinggrass
Copy link
Contributor

Maybe we can integrate this directly into the websocket so it will also work for 1.6

@marcemmers marcemmers force-pushed the MessageLoggingCallback branch from 787c49d to cd5de9f Compare October 17, 2023 09:56
SNSubramanya and others added 3 commits November 3, 2023 11:12
Signed-off-by: Soumya Subramanya <[email protected]>

[wip] fix bug in callback

Signed-off-by: Soumya Subramanya <[email protected]>

[wip] some more testing commits

Signed-off-by: Soumya Subramanya <[email protected]>

Add calls to callback with direction, remove old changes

Signed-off-by: Marc Emmers <[email protected]>

Remove some more old code, move enum to types.hpp

Signed-off-by: Marc Emmers <[email protected]>

Fix rebase issue

Signed-off-by: Marc Emmers <[email protected]>

Fix typo

Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
@hikinggrass hikinggrass force-pushed the MessageLoggingCallback branch from edc5259 to ec585a4 Compare November 3, 2023 10:22
@hikinggrass hikinggrass merged commit 4c30a76 into main Nov 3, 2023
2 checks passed
@hikinggrass hikinggrass deleted the MessageLoggingCallback branch November 3, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants