Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new 'experimental.md' doc for proposed updates to dataset.md #190

Merged
merged 10 commits into from
Mar 24, 2022

Conversation

smrgeoinfo
Copy link
Contributor

@smrgeoinfo smrgeoinfo commented Dec 7, 2021

Based on Discussions at SDO cluster meeting Monday, created new doc, move advanced topics to experimental, add stuff from variableMeasured Tier 4 and anvanced topics from Issue 27 branch. This is to clear the way for the issue27 branch to merge with dev (#168)
addresses #189

Copy link
Member

@ashepherd ashepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Steve! Do you think we should link to it from the Dataset guideline somehow?

@ashepherd ashepherd changed the base branch from master to develop December 27, 2021 18:59
@ashepherd
Copy link
Member

just changed the base of this PR to be develop

@ashepherd ashepherd added this to the v1.3 milestone Jan 3, 2022
@ashepherd
Copy link
Member

ashepherd commented Jan 27, 2022

  • Add description of what this Experimental document is
  • Add Table of Contents (by class Dataset, DataRepository, etc. ten by each applicable section)
  • Link to this from top-level README

@smrgeoinfo
Copy link
Contributor Author

@ashepherd suggestions implemented in Issue189-ExperimentalRecs branch

Copy link
Collaborator

@datadavev datadavev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor edits needed in the examples in Experimental.md as per comment

guides/Experimental.md Outdated Show resolved Hide resolved
@mbjones
Copy link
Collaborator

mbjones commented Feb 7, 2022

From 2022-02-07 SOSO meeting:

  • Steve made updates following the recs last meetings
  • TODO: Examples need to follow the new context loading guidelines
  • TODO: the IGSN @id example should use the “igsn:” prefix
  • Needs review and merge

Copy link
Collaborator

@mbjones mbjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smrgeoinfo Looks good. A few suggested changes, but particularly the context update (which I think I have right in the propose change but was hard to check the syntax in the issue editor).

README.md Outdated Show resolved Hide resolved
guides/Experimental.md Outdated Show resolved Hide resolved
guides/Experimental.md Outdated Show resolved Hide resolved
@ashepherd ashepherd merged commit 028d063 into develop Mar 24, 2022
Copy link
Collaborator

@mbjones mbjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants