Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dynamic constituent routine with register phase #147

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Oct 31, 2024

Originator(s): peverwhee

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): Modifies existing dynamic constituent handling for the MUSICA interface to use the new register phase

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M schemes/musica/musica_ccpp.F90
M schemes/musica/muscia_ccpp.meta

  • remove dynamic_constituent_routine from metadata
  • add necessary comment header to Fortran
  • add metadata for register routine

List any test failures:

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No

@peverwhee peverwhee self-assigned this Oct 31, 2024
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@peverwhee peverwhee requested review from jimmielin and removed request for nusbaume October 31, 2024 22:13
schemes/musica/musica_ccpp.meta Show resolved Hide resolved
@peverwhee peverwhee merged commit de3c61b into ESCOMP:development Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants