Remove 0.5*timestep logic from call to zm #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrher
reviewed
Aug 15, 2024
| @@ -68,9 +68,6 @@ subroutine zm_conv_convtran_run(ncol, pver, & | |||
|
|
|||
| real(kind_phys), intent(in) :: dpdry(:,:) ! Delta pressure between interfaces (ncol,pver) | |||
|
|
|||
| real(kind_phys), intent(in) :: dt ! 2 delta t (model time increment) | |||
There was a problem hiding this comment.
I presume dt is just not used in convtran?
There was a problem hiding this comment.
That is correct - when I went to see if the dt needed adjusting in this routine, I discovered it was not used, so I removed it.
peverwhee
approved these changes
Aug 15, 2024
zhang_mcfarlane/zm_conv_momtran.F90
Outdated
| @@ -59,7 +59,7 @@ subroutine zm_conv_momtran_run(ncol, pver, pverp, & | |||
| real(kind_phys), intent(in) :: ed(:,:) ! Mass entraining from downdraft (ncol,pver) | |||
| real(kind_phys), intent(in) :: dp(:,:) ! Delta pressure between interfaces (ncol,pver) | |||
| real(kind_phys), intent(in) :: dsubcld(:) ! Delta pressure from cloud base to sfc (ncol) | |||
| real(kind_phys), intent(in) :: dt ! time step in seconds : 2*delta_t | |||
| real(kind_phys), intent(in) :: dt | |||
There was a problem hiding this comment.
can we put the ! time step in seconds comment back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZM has for a very long time passed in .5*timestep and then inside multiplied by 2 in several places (and also done 0.5/input_timestep in several other locations). It also hinders CCPP'ization as we do not have a half timestep standard name. This confusing, unnecessary logic will be removed.
To confirm the results, see this email from @adamrher
Your ZM branch has round-off level differences with cam6_4_018, so it's working as expected (plots attached).
Ignore the top right panel "cam6_4_015" -- that's my clubb+mf branch and something is very wrong with that run.