Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to overwrite shr_const values in CESM #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

billsacks
Copy link
Member

This is needed for idealized test cases

NOT YET TESTED: This was a quick change, for review and testing by @gunterl

If we want to be careful about this, we should test to ensure that this doesn't change answers in CESM

This is needed for idealized test cases
@gunterl
Copy link
Contributor

gunterl commented Nov 29, 2018

These changes do not seem to be working as we want.
I tried by setting the value of rhoi in the default namelist and also in user_nl_cism but the value still gets overwritten by the CESM default.

@gunterl
Copy link
Contributor

gunterl commented Nov 30, 2018

Actually it works if an ifndef(CCSMCOUPLED) is removed in libglide/glide_setup.F90.
Let's test this further before moving this change to master.

@billsacks billsacks removed the request for review from gunterl November 30, 2018 17:52
@billsacks billsacks assigned Katetc and unassigned gunterl Nov 30, 2018
@billsacks
Copy link
Member Author

@Katetc - @gunterl has looked at this and it's working for him. I'm assigning it to you because it would be good to coordinate bringing this to master along with generally updating cism-wrapper to point to the latest version of master. I'd feel more comfortable if this were tested in a bit-for-bit tag, which may mean keeping this separate from other updates to master if they have any expected answer changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants