cam6_4_037: Implementation of CCPP-ized tropopause_find with compatibility with current CAM #1135
Conversation
This includes the CCPP-ized tropopause_find and replaces tropopause.F90 with a shim that calls the underlying CCPP-ized routines to maintain bit-for-bit and subroutine call compatibility with existing CAM.
…fining it internally.
There was a problem hiding this comment.
Great work @jimmielin! I have some suggestions to hopefully cleanup the top-level interfaces in CAM and add some extra sanity checks, but otherwise everything looks good.
There was a problem hiding this comment.
Mainly comment changes to make them more "long-term". The comments were appropriate during your development (especially to yourself as you are making the mods). Now that we are getting ready to commit, the comments should be less about what "used to be" and more general comments about what the code is doing.
There was a problem hiding this comment.
Thanks for the changes. I have one minor edit for clarity.
As a side note - I typically use a known string "CACNOTE" for things I need to address before my final commit. That way I can leave notes to myself during development, but can remove them before they become permanent.
Thank you, this is good to know. I leave |
cacraigucar
changed the title
cacraigucar
changed the title
|
All tests passed matching expected pre-existing failures. The Derecho Intel test for SMS FCSD_HCO did not match baseline at initial attempt and was resubmitted and passed w/o any changes. The test is suspect due to reproducibility issues in HEMCO and may be solved by future GEOS-Chem updates... |
|
Baselines (including failed rerun for |
Merge pull request ESCOMP#1135 from jimmielin/hplin/tropopause_find cam6_4_037: Implementation of CCPP-ized tropopause_find with compatibility with current CAM ESCOMP commit: cf436f7
Merge pull request ESCOMP#1135 from jimmielin/hplin/tropopause_find cam6_4_037: Implementation of CCPP-ized tropopause_find with compatibility with current CAM ESCOMP commit: cf436f7
Merge pull request ESCOMP#1135 from jimmielin/hplin/tropopause_find cam6_4_037: Implementation of CCPP-ized tropopause_find with compatibility with current CAM ESCOMP commit: cf436f7
Closes #1121.
Companion PRs:
This brings in
atmospheric_physicswith CCPP-izedtropopause_findand a compatibility wrapper in the place of oldtropopause.F90preserving old behavior and bit-for-bit reproducibility.Minor edits to certain subroutine calls to remove redundant specification of
primary=TROP_ALG_TWMO, backup=TROP_ALG_CLIMATE, as that is the default configuration and such specification is unnecessary.