Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_047: update config component to handle new compset names #1078

Open
wants to merge 7 commits into
base: cam_development
Choose a base branch
from

Conversation

jedwards4b
Copy link

@jedwards4b jedwards4b commented Jul 5, 2024

This adds the C designation for concentration driven experiments, it's not clear to me if the emissions driven experiments will need the same date files or different ones so I've left that out for now.

Fixes #1077
closes #1191
closes #1190
closes #1189

@cacraigucar cacraigucar marked this pull request as draft July 9, 2024 20:20
@jedwards4b
Copy link
Author

@peverwhee I am going to need this change in alpha05b. I need to also add changes for HIST as well as 1850 so I'll work on that and push it back here. This is to support the C and E (Concentration and Emissions driven distinction) addition to compset names as documented in https://docs.google.com/spreadsheets/d/1nJl4lbbwBq60quyaERJ6OvVJxF4kDu4xX7zZenZgyB8/edit?usp=sharing.

@peverwhee
Copy link
Collaborator

ok thanks @jedwards4b. When you move this out of draft, I'll make it the next tag.

@peverwhee peverwhee self-assigned this Nov 13, 2024
@peverwhee peverwhee changed the title update config component to handle new compset names cam6_4_047: update config component to handle new compset names Nov 13, 2024
@jedwards4b jedwards4b marked this pull request as ready for review November 13, 2024 16:05
@jedwards4b
Copy link
Author

I have added the C and E modifiers to compset names for Concentration and Emissions driven cases. As we do not yet have Emissions driven compsets these are both currently pointing to the same cam use cases and stream files.

@peverwhee peverwhee self-requested a review November 13, 2024 16:26
@peverwhee
Copy link
Collaborator

@jedwards4b is this tag waiting on a resolution to #1189 ?

@jedwards4b
Copy link
Author

I think that it would make sense for @fvitt
to add the use case here.

fvitt and others added 4 commits November 15, 2024 13:02
	modified:   bld/namelist_files/mozart_master_gas_drydep_list.xml
	modified:   bld/namelist_files/mozart_master_gas_wetdep_list.xml
	modified:   cime_config/config_component.xml
	modified:   src/cpl/nuopc/atm_stream_ndep.F90

        new file:   bld/namelist_files/use_cases/1850_trop_strat_t4s_cam7.xml
	renamed:    bld/namelist_files/use_cases/hist_trop_strat_ts4_cam7.xml -> bld/namelist_files/use_cases/hist_trop_strat_t4s_cam7.xml
	modified:   bld/namelist_files/use_cases/1850_trop_strat_t4s_cam7.xml
	modified:   bld/namelist_files/use_cases/hist_trop_strat_t4s_cam7.xml
@peverwhee
Copy link
Collaborator

@jedwards4b I'm going to kick off the tests, but can you confirm that Francis's use cases fix your error when you a get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants