Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBSDEF-44980] Show pagination footer with page sizes dropdown only if number of records are greater than 10 #283

Merged
merged 2 commits into from
May 15, 2024

Conversation

akate1
Copy link
Contributor

@akate1 akate1 commented May 14, 2024

OBSDEF-44980

Summary of the Change

  • Added code to show pagination footer with page sizes dropdown only if the total number of records are greater than 10
  • Created story for same

Screenshot/GIF

Before

NA

After

Storybook:

image

Objectscale Portal UI:
image

Where to test ?

Storybook :
http://10.227.234.153:6006/?path=/story/datagrid--grid-with-pagination-and-pagesizes-dropdown

ObjectScale Portal UI:
http://10.227.234.153:3000/#

Scenarios verified/Documentation link

List all the scenarios verified for the changes or link to the manual test documentation for new features

Peer Tester Name

Add team member's name who will test your PR
@netraja-chavan

Copy link
Contributor

@netraja-chavan netraja-chavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

Copy link
Contributor

@psivakumaran psivakumaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akate1 akate1 merged commit 143977b into main May 15, 2024
1 check passed
@akate1 akate1 deleted the bugfix-OBSDEF-44980 branch May 15, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants