Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OBSDEF-46956] DataGrid Pagination Improvments: Revert default prop changes for PageSizes #282

Merged
merged 7 commits into from
Apr 29, 2024
Merged

[OBSDEF-46956] DataGrid Pagination Improvments: Revert default prop changes for PageSizes #282

merged 7 commits into from
Apr 29, 2024

Conversation

akate1
Copy link
Contributor

@akate1 akate1 commented Apr 29, 2024 •
edited
Loading

OBSDEF-45527

Summary of the Change

  • Made Pagination -> PageSizes prop as optional
  • Remove all changes related to default prop for PageSizes
  • Added validation for custom page size input for accepting only number values
  • Replace deprecated evt.keycode with evt.key
  • Create constant for "Custom" option
  • Create enum for common Keyboard keys
  • Updated missing documentation

Screenshot/GIF

Before

NA

DatagridCustomPageSizes

After

Where to test ?

http://10.227.234.153:6006/?path=/story/datagrid--grid-with-pagination-and-pagesizes-dropdown

Scenarios verified/Documentation link

List all the scenarios verified for the changes or link to the manual test documentation for new features

Peer Tester Name

Add team member's name who will test your PR
@netraja-chavan

@akate1 akate1 requested review from Malayvarma27 and GauravMenezes-Professional and removed request for ben-schumacher and girishdudhe April 29, 2024 09:14
Malayvarma27
Malayvarma27 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Malayvarma27 Malayvarma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the custom input. LGTM

netraja-chavan
netraja-chavan approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@netraja-chavan netraja-chavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested storybook link with custom page size
LGTM

psivakumaran
psivakumaran approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@psivakumaran psivakumaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akate1 akate1 merged commit e49d8d3 into main Apr 29, 2024
1 check passed
@akate1 akate1 deleted the feature-OBSDEF-46956 branch April 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netraja-chavan netraja-chavan netraja-chavan approved these changes

@Malayvarma27 Malayvarma27 Malayvarma27 approved these changes

@psivakumaran psivakumaran psivakumaran approved these changes

@maheshkulkarni4 maheshkulkarni4 Awaiting requested review from maheshkulkarni4 maheshkulkarni4 is a code owner

@ShitalSD ShitalSD Awaiting requested review from ShitalSD ShitalSD is a code owner

@m-manaswini m-manaswini Awaiting requested review from m-manaswini m-manaswini is a code owner

@Bhatii Bhatii Awaiting requested review from Bhatii Bhatii is a code owner

@tejasjc-ecs tejasjc-ecs Awaiting requested review from tejasjc-ecs

@GauravMenezes-Professional GauravMenezes-Professional Awaiting requested review from GauravMenezes-Professional

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akate1 @psivakumaran @Malayvarma27 @netraja-chavan