Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General config and run_reframe.sh for local and EESSI stack #200

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laraPPr
Copy link
Collaborator

@laraPPr laraPPr commented Oct 31, 2024

The updates to the run_reframe.sh scripts as they will pickup the default enviroment which does:
unset MODULEPATH and sets EESSI enviroment

if [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then
eessi_init_path="${EESSI_CVMFS_REPO}"/versions/"${EESSI_VERSION}"/init/bash
source "${eessi_init_path}"
fi

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an alternative to load a local module environment? Might not be needed on your systems. On our system we'd have to load a meta-module (e.g. 2023, or 2024) to make a software environment available.

fi
if [ -z "${EESSI_VERSION}" ]; then
export EESSI_VERSION=2023.06
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] | [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then
Copy link
Collaborator

@casparvl casparvl Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting:

$ EESSI_CI_SYSTEM_NAME=surf_snellius ./run_reframe.sh
Running CI on host int5
/tmp/EESSI-test-suite/CI
./run_reframe.sh: line 53: [: ==: unary operator expected

Also, when USE_EESSI_SOFTWARE_STACK was empty, it didn't get set by default (which seems to me is what you were trying to do here). The reason is you're using a single | instead of ||.

Both be resolved by:

Suggested change
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] | [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] || [ "$USE_EESSI_SOFTWARE_STACK" == "True" ]; then

if [ $UNSET_MODULEPATH == "True" ]; then
unset MODULEPATH
fi
if [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then
if [ "$USE_EESSI_SOFTWARE_STACK" == "True" ]; then

unset MODULEPATH
eessi_init_path="${EESSI_CVMFS_REPO}"/versions/"${EESSI_VERSION}"/init/bash
source "${eessi_init_path}"
if [ $UNSET_MODULEPATH == "True" ]; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ $UNSET_MODULEPATH == "True" ]; then
if [ "$UNSET_MODULEPATH" == "True" ]; then

if [ -z "${EESSI_VERSION}" ]; then
export EESSI_VERSION=2023.06
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] | [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then
export USE_EESSI_SOFTWARE_STACK=True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to print some more of these variables in the section that also prints reframe config etc. Makes things easier to debug.

Copy link
Collaborator

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are needed to the run_reframe.sh to make things work on surf_snellius. I'll leave testing/reviewing the hortense-specific stuff to @smoors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants