-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General config and run_reframe.sh
for local and EESSI stack
#200
base: main
Are you sure you want to change the base?
Conversation
if [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then | ||
eessi_init_path="${EESSI_CVMFS_REPO}"/versions/"${EESSI_VERSION}"/init/bash | ||
source "${eessi_init_path}" | ||
fi | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have an alternative to load a local module environment? Might not be needed on your systems. On our system we'd have to load a meta-module (e.g. 2023
, or 2024
) to make a software environment available.
fi | ||
if [ -z "${EESSI_VERSION}" ]; then | ||
export EESSI_VERSION=2023.06 | ||
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] | [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting:
$ EESSI_CI_SYSTEM_NAME=surf_snellius ./run_reframe.sh
Running CI on host int5
/tmp/EESSI-test-suite/CI
./run_reframe.sh: line 53: [: ==: unary operator expected
Also, when USE_EESSI_SOFTWARE_STACK
was empty, it didn't get set by default (which seems to me is what you were trying to do here). The reason is you're using a single |
instead of ||
.
Both be resolved by:
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] | [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then | |
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] || [ "$USE_EESSI_SOFTWARE_STACK" == "True" ]; then |
if [ $UNSET_MODULEPATH == "True" ]; then | ||
unset MODULEPATH | ||
fi | ||
if [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then | |
if [ "$USE_EESSI_SOFTWARE_STACK" == "True" ]; then |
unset MODULEPATH | ||
eessi_init_path="${EESSI_CVMFS_REPO}"/versions/"${EESSI_VERSION}"/init/bash | ||
source "${eessi_init_path}" | ||
if [ $UNSET_MODULEPATH == "True" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if [ $UNSET_MODULEPATH == "True" ]; then | |
if [ "$UNSET_MODULEPATH" == "True" ]; then |
if [ -z "${EESSI_VERSION}" ]; then | ||
export EESSI_VERSION=2023.06 | ||
if [ -z "${USE_EESSI_SOFTWARE_STACK}" ] | [ $USE_EESSI_SOFTWARE_STACK == "True" ]; then | ||
export USE_EESSI_SOFTWARE_STACK=True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to print some more of these variables in the section that also prints reframe config etc. Makes things easier to debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are needed to the run_reframe.sh
to make things work on surf_snellius
. I'll leave testing/reviewing the hortense-specific stuff to @smoors
The updates to the
run_reframe.sh
scripts as they will pickup the default enviroment which does:unset MODULEPATH
and sets EESSI enviroment