Skip to content

Commit

Permalink
Ignored some tests for Miri
Browse files Browse the repository at this point in the history
- model jacobian test, because of stacked borrows issue inside ViewStorage (help wanted!?)
- stddev test, as it took too long
  • Loading branch information
Dzuchun committed Nov 21, 2024
1 parent 1d2f0b8 commit 88f7331
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions nacfahi/src/models/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ macro_rules! test_model_derivative {
($name:path, $model:expr, [$(($x:expr, $y:expr)),*]) => {
#[cfg(test)]
#[test]
#[cfg_attr(miri, ignore = "Miri gets angry because of stacked borrows rules somewhere inside nalgebra's storage. The thing is, my own storage implementation IS USED NEARBY (generic_array_storage one), so I AM SCARED PWEASE DOWT HWT MW")]
#[allow(clippy::too_many_lines, unused_imports)]
fn model_numeric_test() {
use ::generic_array_storage::{Conv, GenericMatrixExt, GenericMatrixFromExt};
Expand Down
1 change: 1 addition & 0 deletions nacfahi/tests/errors_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use num_traits::FromPrimitive;
use rand::{thread_rng, Rng};

#[test]
#[cfg_attr(miri, ignore = "Takes TOO LONG")]
fn constant_stdev() {
// some data, x can be whatever
const SAMPLE_SIZE: usize = 10_000;
Expand Down

0 comments on commit 88f7331

Please sign in to comment.