Properly test whether an operand is an EVEX mask to apply braces during disassembly #7152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng disassembly. Convention is that EVEX mask operands (but not other opmask register operands) are disassembled in braces. The correct test here is to test the optype, which avoids applying the braces to a number of other opmask register operands (see the changes in the disassembly tests for examples).
derekbruening
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convention is that EVEX mask operands (but not other opmask register operands) are disassembled in braces. The correct test here is to test the optype, which avoids applying the braces to a number of other opmask register operands (see the changes in the disassembly tests for examples).