i#6831 sched refactor, step 7: Split eof_or_idle #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits set_initial_schedule() into separate overrides in the 3 scheduler subclasses, sharing the initial content reading in init() prior to calling set_initial_schedule(). Splits set_output_active(): it is only valid in dynamic. Moves rebalance_queues() and two rebalance vars to dynamic. Moves read_recorded_schedule() and read_and_instantiate_traced_schedule() to replay. Adds more using statements to remove the need for "this->" prefixes on frequent base class member field references. Issue: #6831
Splits eof_or_idle() into separate overrides in the 3 scheduler subclasses. This then allows moving pop_from_ready_queue*() into the dynamic subclass. Moves process_markers(), ready_queue_empty(), and syscall_incurs_switch() into the dynamic subclass. Issue: #6831
abhinav92003
approved these changes
Nov 14, 2024
|
a64 failure is the thread exit before a bundle #3320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits eof_or_idle() into separate overrides in the 3 scheduler subclasses. This then allows moving pop_from_ready_queue*() into the dynamic subclass.
Moves process_markers(), ready_queue_empty(), and
syscall_incurs_switch() into the dynamic subclass.
Issue: #6831