i#4103 clang-tidy: Mark hierarchical headers for IWYU #7073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds clang-tidy annotations to the deliberately hierarchical headers in core DR where one header is meant to include a set of other headers. This avoids clang-tidy Include What You Use complaints which can cause users to include individual sub-headers, which sometimes have ordering constraints if the top-level header is not included first (or solely). Issue: #4103
|
The failures are all bugs in clang-format-diff where with its smaller context it doesn't match clang-format on the whole file. Probably best to override and check in what full clang-format says; the next change to globals_shared.h is just going to hit the same problem so me reverting just that part of the file won't help long-term. |
ivankyluk
approved these changes
Nov 11, 2024
|
3 of the failures are the aforementioned clang-format-diff; the x64 failure is type_is_instr #3320. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds clang-tidy annotations to the deliberately hierarchical headers in core DR where one header is meant to include a set of other headers. This avoids clang-tidy Include What You Use complaints which can cause users to include individual sub-headers, which sometimes have ordering constraints if the top-level header is not included first (or solely).
Issue: #4103