i#3544: RV64: Mangle pc-relative addressing destining to tp #7068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PC-relative addressing is done through auipc on RISC-V, which comes with
only one register operand, so it's always safe to use a0 here.
This handles code sequence like
```
_start:
lla tp, slot
lw a0, 0(tp)
li a7, 93
ecall
slot: .long 0x5a
```
Issue: DynamoRIO#3544
ksco
approved these changes
Nov 6, 2024
derekbruening
approved these changes
Nov 7, 2024
ksco
approved these changes
Nov 7, 2024
derekbruening
approved these changes
Nov 7, 2024
|
I think this PR is ready for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse mangle_stolen_reg_and_tp_reg() to simplify register spilling.
This handles code sequence like
Issue: #3544